[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#60069] [PATCH 2/2] guix-install.sh: Directly exit in case of errors
From: |
Maxim Cournoyer |
Subject: |
[bug#60069] [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. |
Date: |
Wed, 14 Dec 2022 13:17:42 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi Tobias,
Tobias Geerinckx-Rice <me@tobias.gr> writes:
> Maxim Cournoyer 写道:
>> - [ "${#warn}" -ne 0 ] &&
>> - { _err "${ERR}Missing commands: ${warn[*]}.";
>> - return 1; }
>> - + [ "${#warn}" -ne 0 ] && die "Missing commands:
>> ${warn[*]}."
>> +
>
> I did not run this, but will it not itself trigger -e when the test
> is false?
This apparently falls in the special casing by Bash of what is
considered a failure when using 'set -e'; here's a test:
--8<---------------cut here---------------start------------->8---
$ cat test.sh
#!/usr/bin/env bash
set -e
[ false ] && echo "hey, we made it!"
--8<---------------cut here---------------end--------------->8---
--8<---------------cut here---------------start------------->8---
$ ./test.sh
hey, we made it!
--8<---------------cut here---------------end--------------->8---
I hope this answers your question.
--
Thanks,
Maxim
- [bug#60068] [PATCH 1/2] guix-install.sh: Add GUIX_ALLOW_OVERWRITE environment variable., Maxim Cournoyer, 2022/12/14
- [bug#60068] [PATCH 1/2] guix-install.sh: Add GUIX_ALLOW_OVERWRITE environment variable., Tobias Geerinckx-Rice, 2022/12/14
- [bug#60068] [PATCH v2 1/3] guix-install.sh: Add missing "useradd" command., Maxim Cournoyer, 2022/12/14
- [bug#60068] [PATCH v2 3/3] guix-install.sh: Directly exit in case of errors in chk_require., Maxim Cournoyer, 2022/12/14
- [bug#60068] bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require., Ludovic Courtès, 2022/12/15