[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#60068] bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in cas
From: |
Maxim Cournoyer |
Subject: |
[bug#60068] bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. |
Date: |
Fri, 16 Dec 2022 00:07:24 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi Ludovic,
Ludovic Courtès <ludo@gnu.org> writes:
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> The need for this use case appeared when attempting to install Guix on a
>> truly
>> minimal image made with Buildroot, which lacked enough GNU components that I
>> had to extract a guix pack to /gnu before attempting installation, which
>> would
>> then refuse to proceed because of the existing /gnu.
>>
>> * etc/guix-install.sh: Document environment variables.
>> (sys_create_store) [GUIX_ALLOW_OVERWRITE]: Skip pre-existing installation
>> checks and output a warning. Extract the tarball directly to /.
>
> Like Tobias, I’m reluctant to adding environment variables; I’m also
> skeptical about the use case (I think it’s fine to let users remove
> their previous installation if that’s what they want).
Removing my previous installation wouldn't have helped (it would have
cleared the guix packs I needed to be able to run the installer).
Without this change, I wouldn't have been able to install guix using
guix-install.sh. It's niche, but I bet it'd help folks trying to
install Guix on Alpine and similar minimal OSes.
> I also think we’d rather minimize changes to the script since we’re a
> couple of days before the release.
The change seems fairly small to me and would be easy to revert if it
causes a problem. But I'll let you do the call, given you're the one
pushing the release forward (thank you!).
--
Thanks,
Maxim
- [bug#60068] [PATCH 1/2] guix-install.sh: Add GUIX_ALLOW_OVERWRITE environment variable., Maxim Cournoyer, 2022/12/14
- [bug#60068] [PATCH 1/2] guix-install.sh: Add GUIX_ALLOW_OVERWRITE environment variable., Tobias Geerinckx-Rice, 2022/12/14
- [bug#60068] [PATCH v2 1/3] guix-install.sh: Add missing "useradd" command., Maxim Cournoyer, 2022/12/14
- [bug#60068] [PATCH v2 3/3] guix-install.sh: Directly exit in case of errors in chk_require., Maxim Cournoyer, 2022/12/14
- [bug#60068] bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require., Ludovic Courtès, 2022/12/15