guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#63839] [PATCH] gnu: riscv-pk: don't target riscv64-linux-gnu when c


From: Josselin Poiret
Subject: [bug#63839] [PATCH] gnu: riscv-pk: don't target riscv64-linux-gnu when current system is riscv64.
Date: Tue, 06 Jun 2023 17:48:40 +0200

Hi,

Z572 via Guix-patches via <guix-patches@gnu.org> writes:


> +      ;; riscv-pk can only be built for riscv64.
> +      (if (string-prefix? "riscv64" (%current-system))
> +          '()
> +          (list
> +           #:target "riscv64-linux-gnu"))

I don't think that's a good idea, in general, consumers of the package
should be the ones specifying for which arch this package builds.  For
that purpose, there's the supported-systems field of the package record
type.  It's not good in general to hardcode targets in package
definitions.

Best,
-- 
Josselin Poiret

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]