[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#63839] [PATCH] gnu: riscv-pk: don't target riscv64-linux-gnu when c
From: |
Z572 |
Subject: |
[bug#63839] [PATCH] gnu: riscv-pk: don't target riscv64-linux-gnu when current system is riscv64. |
Date: |
Sun, 11 Jun 2023 22:48:20 +0800 |
User-agent: |
mu4e 1.10.2; emacs 30.0.50 |
Josselin Poiret via Guix-patches via <guix-patches@gnu.org> writes:
> [[PGP Signed Part:Undecided]]
> Hi,
>
> Z572 via Guix-patches via <guix-patches@gnu.org> writes:
>
>
>> + ;; riscv-pk can only be built for riscv64.
>> + (if (string-prefix? "riscv64" (%current-system))
>> + '()
>> + (list
>> + #:target "riscv64-linux-gnu"))
>
> I don't think that's a good idea, in general, consumers of the package
> should be the ones specifying for which arch this package builds. For
> that purpose, there's the supported-systems field of the package record
> type. It's not good in general to hardcode targets in package
> definitions.
look it's name.
because it doesn't make sense to target other targets, like
`u-boot-sifive-unmatched' or `opensbi-generic'.
>
> Best,
--
over