Re: [H-client-devel] Questions about the python3-port branch in the git repo

[Yuchen Pei]

On Sun 2022-06-19 22:18:50 -0400, Maxim Cournoyer wrote:

> Hi Yuchen,
>
> Yuchen Pei <hi@ypei.me> writes:
>
>> On Thu 2022-06-16 14:19:01 -0400, Maxim Cournoyer wrote:
>>
>>> Hello Yuchen,
>>>
>>> Yuchen Pei <hi@ypei.me> writes:
>>>
>>>> I had a cursory look at the python3-port branch[0], which is a port to
>>>> python3/gtk3 according to [1], and I have some quick questions:
>>>>
>>>> 1. The tree looks a bit weird: it contains an h-client subdir[2] which 
>>>> looks
>>>> identical to the tree[0] itself sans the h-client subdir, why?
>>>
>>> Yes; I noticed that too.  At some point in the history it gets removed;
>>> I think it had to be that way to be able to merge both SVN histories as
>>> one.
>>>
>>>> 2. The README.txt[3] still says python 3 is not supported.  Perhaps it
>>>> needs updating?
>>>
>>> Right.  We'll want to cut a proper release I think and take care of
>>> these things.  The python3-port branch is already used in Guix; I had
>>> made sure it works at least as well as the old Python 2 code base.
>>>
>>> I suggest we wait a bit to see what Bill thinks about their progress on
>>> (much welcome!) UI improvements.  If they are satisfied and development
>>> reaches some milestone soon, we could test it, merge it to master
>>> (deleting the now obsolete python3-port branch) and release from master.
>>
>> Do you mean merging the UI improvements into master as well?
>
> Yes (to be clear, I meant the current 'main' branch when I wrote
> 'master'), after they are reviewed or at least tested.

Thanks for clarifying, that sounds good.

>
> Thanks,
>
> Maxim


Best,
Yuchen

-- 
PGP Key: 47F9 D050 1E11 8879 9040  4941 2126 7E93 EF86 DFD0
          <https://ypei.org/assets/ypei-pubkey.txt>