[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Health-dev] More Trytonic style coding guidelines for GnuHealth
From: |
Oscar Alvarez |
Subject: |
[Health-dev] More Trytonic style coding guidelines for GnuHealth |
Date: |
Sat, 27 Sep 2014 13:22:30 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 |
Hi Devs
I would like to propose you to do little changes, for improvement coding
design of some modules of Gnuhealth, the changes are:
1. Some Class has not to follow conventional order for the
fields-methods, example HealthProfessional, because first defines a
classmethod (get_health..) and next the fields, this for new developers
is a little confuse.
2. I think that file health.py in main base module must be splitted in
three files:
- health.py (All modules except party and product related)
- party.py (with PartyPatient and PartyAddress)
- product.py (with Product, ProductCategory, ...)
this let's understand/debug to better way this big and great module.
3. The naming some view files doesn't follow tryton convention, for example:
"gnuhealth_health_service.xml", must be
"gnuhealth_health_service_form.xml", the last word "form" is missing,
news developer has guess what kind of file is this xml.
I can to work around this changes, If you are agree ¿?,
Thanks, I hope your opinions.
Oscar Alvarez
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Health-dev] More Trytonic style coding guidelines for GnuHealth,
Oscar Alvarez <=