Re: Possible bug in cfenvd.c

[Mark . Burgess]

Thank you very much. This is definitely a typo/bug, which might explain
why cfenvd uses a lot of cpu. This has been a mystery to me and was the next
thing on my list... I don't see how it would make it use a lot of
memory though...

Anyway, I'll test this out.

thanks,
Mark


On 15 Feb, Rune Mossige wrote:
> Trying cfengine-2.0.a23 on a Solaris2.6 box revealed a possible bug.
> 
> After cfenvd had been running for a while (an hour or so), we noticed
> that it was using a huge amount of memory.
> 
> We then forced a core dump, and ran it via gdb, and this showed that it
> stopped in line 767:
> 767        for (sp = ip->name; sp != '\0'; sp++)
>                               ^^^
> 
> This, to us, did not look correct. We supposed that this should be
> using 'for (sp = ip->name; *sp != '\0'; sp++)' instead. We made this
> change, re-compiled cfenvd.c, and it have now been running for several
> hours without consuming any abnormal cpu time.
> 
> A diff show:
> 
> diff cfenvd.c cfenvd.c-DIST
> 767c767
> <    for (sp = ip->name; *sp != '\0'; sp++)
> ---
>>    for (sp = ip->name; sp != '\0'; sp++)
> 
> If this really is a bug, we would like to see this fixed in the next
> beta release.
> 



~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Work: +47 22453272            Email:  Mark.Burgess@iu.hio.no
Fax : +47 22453205            WWW  :  http://www.iu.hio.no/~mark
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~