Re: [Koha-devel] Patch for Koha 2.2.0RC2

[Andrés Tarallo]

Let me know when you have it commited into the CVS. I'm aware that many 
of my patches are not elegant or clean. While I work in the conversion 
of my database I'm improving my perl abilities and learning html 
template among other things.

Andres

Paul POULAIN wrote:

> Andrés Tarallo a écrit :
>
> > When you display the detail of a biblio the word subject (in bold) 
> > doesnt appears, it just appears the subjects. However with my patch 
> > this word appears.
> >
> > Maybe someone with a deeper knowldge of html templates can give a 
> > more elegant solution, this one just works ;).
>
>
> That's what I thought :
> In this case, my patch is better :
> show "subject(s):" before subject(s) if there is at least one.
> If there is none, show nothing. so i commit mine (and thank you for 
> the report even if the solution was not the best ;-) )
>
> > > I don't understand what it does : it just hide (in opac-main.tmpl) 
> > > the :
> > >                <!-- TMPL_IF name="subject" --><b>Subject:</b><!-- 
> > > /TMPL_IF -->
> > >
> > > So I think it's better to change this line into
> > >                <!-- TMPL_IF name="subjects" 
> > > --><b>Subject(s):</b><!-- /TMPL_IF -->
> > > to have "Subject(s): " before the subjects when there is at least one.