[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Koha-devel] Confusion over this bit of code in Circ2.pm
From: |
bob |
Subject: |
[Koha-devel] Confusion over this bit of code in Circ2.pm |
Date: |
Wed, 7 Jun 2006 12:33:14 +1200 (NZST) |
User-agent: |
SquirrelMail/1.4.5 |
Hi,
I am looking at committing katipo koha changes back to cvs and i noticed
this bit of code variation
katipo (older) version:
my ($resfound, $resrec) =
CheckReserves($iteminformation->{'itemnumber'});
if ($resfound and not $ignoreRs) {
$resrec->{'ResFound'} = $resfound;
$messages->{'ResFound'} = $resrec;
$dotransfer = 0;
}
#actually do the transfer....
if ($dotransfer) {
dotransfer($iteminformation->{'itemnumber'}, $fbr, $tbr);
$messages->{'WasTransfered'} = 1;
}
newer version on Savannah cvs:
my ($resfound, $resrec) =
CheckReserves($iteminformation->{'itemnumber'});
if ($resfound and not $ignoreRs) {
$resrec->{'ResFound'} = $resfound;
# $messages->{'ResFound'} = $resrec;
$dotransfer = 1;
}
if ($dotransfer and not $resfound) {
dotransfer($iteminformation->{'itemnumber'}, $fbr, $tbr);
$messages->{'WasTransfered'} = 1;
}
i'm confused as to what the newer version of code is trying to achieve,
the way i read it (and i might be wrong) is that it is saying that if a
reserve is found, and the ignore reserve is false (ie. do not ignore
reserve), allow dotransfer but then the next bit says if dotransfer and
not reserve found then allow transfer which seems to be contrary to the
first bit
any help to understanding the change will be most appreciated
thanks,
Robert Lyon
- [Koha-devel] Confusion over this bit of code in Circ2.pm,
bob <=