Re: [Libunwind-devel] Enabling test suite on Ubuntu 12.10

[James Page]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Arun

On 25/07/12 04:23, Arun Sharma wrote:
>>> 
>>> My feel is that its probably not feasible to use the libunwind
>>> test suite to gate package entry into the Ubuntu archive as
>>> part of the package build process but I wanted to get an
>>> opinion on:
>>> 
>>> a) Whether I am correct in this assumption b) Whether any of
>>> the test failures in the attached document are cause for
>>> concern.
>>> 
> I can comment on amd64, which is my primary development platform. 
> The 4 failures that you see are well known and not a cause for
> concern.
> 
> I'd recommend gating the package entry based on test failures at
> least for amd64.

Thanks for the guidance; I'm currently running with the following
patches to ensure the test suite executes:

Index: libunwind/tests/test-ptrace.c
===================================================================
- --- libunwind.orig/tests/test-ptrace.c  2012-07-30 10:05:35.271168000
+0100
+++ libunwind/tests/test-ptrace.c   2012-07-30 11:39:37.309158623 +0100
@@ -182,6 +182,11 @@

       /* automated test case */
       argv = args;
+
+      /* Unless the args array is 'walked' the child
+         process is unable to access it and dies with a segfault */
+      fprintf(stderr, "Automated test (%s,%s,%s,%s)\n",
+              args[0],args[1],args[2],args[3]);
     }
   else if (argc > 1)
     while (argv[optind][0] == '-')

I'm not entirely sure I understand why the above works; I actually
added this to see why the test was failing - at which point it started
passing again.

Index: libunwind/tests/Gtest-nocalloc.c
===================================================================
- --- libunwind.orig/tests/Gtest-nocalloc.c   2012-07-30
10:05:35.271168000 +0100
+++ libunwind/tests/Gtest-nocalloc.c    2012-07-30 10:17:34.794107721
+0100
@@ -123,6 +123,8 @@
     if (pthread_key_create (&key, NULL))
       panic ("FAILURE: unable to create key %d\n", i);
   }
+  do_backtrace();
+  num_mallocs = num_callocs = 0;
   foo1 ();
   num_errors = num_mallocs + num_callocs;
   if (num_errors > 0)

Picked from the gperftools ML.

I've described the above two patches above as workarounds as neither
actually addresses the underlying problem AFAIK.

I've also disabled the *-dyn1 tests and cherry picked a fix to resolve
the setjmp test failure from the libunwind git repo.

Does this sound reasonable?

Thanks again for your help.

Cheers

James

- -- 
James Page
Ubuntu Core Developer
Debian Maintainer
address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJQFmwMAAoJEL/srsug59jDUVMP+QHY+pt4Da+DHsLOV5tU938r
fpUf3CROGI1rWY7i5MKKTWu3aJxiv+moKZN/YFxyUAz8irz9l9UDEU4KUW88AX1a
mww/BuGlx0KZw3nXf8oXvvbrAd05TuOOHLk2na9gULpiz7jllbDlYpY9DP28IRp1
rvV8YStyqBrC1udl1Q6I0gnkEh6lrRkPjkAsOVEFYBgOdWTsMfpSy9vCi+RhtKE2
HuL2mesT/nl2p7lpkPAYeZKjM/6YyWRX0YL1cVoLn1xS+mtfGU9SFMZMUbMiQrzr
X5Js2AJtswLcQ3kmms5FU7texenmoKTVQna5R1FOfEND9ximLGl0Q07rZS1yH9Gx
h1wu1K+MzMXUG4OrUwGv3DVKqDA2qgUmvgiDC9c5X+KfTgznD8Nh5wXafSN+lknk
Ex5k+LoMM6YxPx9jUhqGt1MqMTHLFVtsMhYw5biVlFqIddqPXYoKnohgkByD8iCX
66DNF1fq1AgH1CPGKSZlYp91ACxdDOQReXYW3LAKVLF8KYxK6UvgHTJPHAzfQzp6
trlZNr92vjkLAECPVAPxprTf9wCZptJQ4giWxr5TPbNM4S24myzsckuPSA0GEWp8
rPhd2FG7ETWKhHEs+KMyRF3C6Zg7V7DwajqWKG3KWPhHW/qgj5ft8bdo6+ACvyr2
oelWoHzGFpenW69grVP/
=kRrA
-----END PGP SIGNATURE-----