Re: [Libunwind-devel] [PATCH] Check that the CIE is within the segment

[Arun Sharma]

On Thu, Dec 4, 2014 at 7:30 PM, Peter Wu <address@hidden> wrote:
> On Thursday 04 December 2014 14:00:53 Arun Sharma wrote:
>> The logic looks good to me. Could you resend the patch replacing tabs
>> with spaces?
>
> The context did not have tabs, so I followed that and used spaces too.
> Where do you see tabs? Are you referring to the number of spaces?
>

My bad. I had indent-with-notabs instead of tab-in-indent in my git config.

>> On Wed, Nov 26, 2014 at 2:40 AM, Peter Wu <address@hidden> wrote:
>> > Due to a bug in the gold linker[1], the .eh_frame and .eh_frame_hdr
>> > sections contains garbage. When dwarf_extract_proc_info_from_fde tried
>> > to look up the begin of the CIE subsection, it would underflow the
>> > .eh_frame segment, resulting in a crash[2].
>> >
>> > This patch avoids that crash by checking whether the CIE pointer is
>> > located after the begin of the .eh_frame section. The variable "base"
>> > was misused in various places as a boolean (decode as .debug_frame or

>> May be cleaner to use debug_frame_base != 0 to indicate that it's a boolean.
>
> Sure, should I send a new patch or will you fix it up locally?

I fixed it up. Thanks!

 -Arun