Re: Introduce breakingRehearsalMarks for line-breaking RehearsalMarks (issue 577180043 by address@hidden)

[nine . fierce . ballads]

On 2019/12/07 22:44:16, thomasmorley651 wrote:

> In one of your linked patches, you define a new grob, DepartureMark. I
already
> thought about something along these lines: we currently have
MetronomeMark and
> RehearsalMark, a new one accepting text only wouldn't be wrong. Though
I'd
> called it TextMark not DepartureMark, it is more general imho, because
not all
> text may be departure instructions.

Adding a type for jumps (as I think we agreed to call them later in the
review) is
important because as a group, they should be styled differently than
rehearsal
marks, depending on the kind of score: above the staff in a vocal part,
below in
an instrumental part, and with different alignment and
break-positioning.  The
question is then, would you want all TextMarks to follow along when
"D.C." etc.
are moved?  I think you might just want to have RehearsalMark and
JumpMark,
each with a clear primary purpose, and provide ways to stretch the use
of either.

> Though, iiuc this new grob doesn't include the ability to be printed
differently
> at line-end/start, but the here proposed function could do so (with
small
> modifications).

I'm starting to look at your change now.

https://codereview.appspot.com/577180043/