[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: Issue 5639: compile with -std=c++11 (issue 553310045 by address@hidd
|
From: |
lilypond |
|
Subject: |
RE: Issue 5639: compile with -std=c++11 (issue 553310045 by address@hidden) |
|
Date: |
Sun, 15 Dec 2019 12:31:24 +0100 |
> -----Original Message-----
> From: address@hidden <address@hidden>
> Sent: Saturday, December 14, 2019 8:52 PM
> To: address@hidden; address@hidden; address@hidden;
> address@hidden; address@hidden
> Cc: address@hidden; address@hidden
> Subject: Re: Issue 5639: compile with -std=c++11 (issue 553310045 by
> address@hidden)
>
> On 2019/12/14 18:23:08, lilypond_de-wolff.org wrote:
> > Great job, one remark:
> > Although the patch for ly/music-functions-init.ly is a good patch, I
> do not
> > think it should be part of this patch-set.
>
> > Jaap
>
>
> It's part of the commit titled "comments." What do you suggest I do instead?
>
>
> https://codereview.appspot.com/553310045/
[>]
It is not the commit title, but I do think that this is not a part of issue
5639: compile with --std=c11
The reason that I think it is important to keep this separated is that the
impact is very different.
When a commit with only comments is in a separate issue, it is easy to cherry
pick it for let say version 2.0.
Although you make it a separate commit, in rietveld it is still one issue.
Jaap