[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 7b62d49 21/46: Rename table_type_converter::g
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 7b62d49 21/46: Rename table_type_converter::get_by_value() to just get() |
Date: |
Wed, 22 Jul 2020 11:05:12 -0400 (EDT) |
branch: master
commit 7b62d49389987db5bb64e039ba7695ff00eeef63
Author: Vadim Zeitlin <vadim@tt-solutions.com>
Commit: Vadim Zeitlin <vadim@tt-solutions.com>
Rename table_type_converter::get_by_value() to just get()
This makes wxGrid-based version consistent with the existing wxDVC-based
one and also is more consistent with get_impl() name, which is the
function used for implementing get().
No real changes.
---
census_view.cpp | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/census_view.cpp b/census_view.cpp
index b2e7ead..519c8b1 100644
--- a/census_view.cpp
+++ b/census_view.cpp
@@ -1178,7 +1178,7 @@ class table_type_converter
virtual void register_data_type(wxGrid* grid) const = 0;
static void register_all(wxGrid* grid);
- static table_type_converter const& get_by_value(any_member<Input> const&
value);
+ static table_type_converter const& get(any_member<Input> const& value);
private:
template<typename T>
@@ -1392,7 +1392,7 @@ table_type_converter::register_all(wxGrid* grid)
}
table_type_converter const&
-table_type_converter::get_by_value(any_member<Input> const& value)
+table_type_converter::get(any_member<Input> const& value)
{
if(exact_cast<mce_yes_or_no>(value))
{
@@ -1594,7 +1594,7 @@ wxString CensusViewGridTable::GetValue(int row, int col)
}
auto const& cell = cell_at(row, col);
- auto const& conv = table_type_converter::get_by_value(cell);
+ auto const& conv = table_type_converter::get(cell);
return conv.to_renderer_value(cell.str());
}
@@ -1603,7 +1603,7 @@ void CensusViewGridTable::SetValue(int row, int col,
wxString const& value)
LMI_ASSERT(col != Col_CellNum);
auto& cell = cell_at(row, col);
- auto const& conv = table_type_converter::get_by_value(cell);
+ auto const& conv = table_type_converter::get(cell);
auto const& prev_val = cell.str();
auto const& new_val = conv.from_editor_value(value);
@@ -1628,7 +1628,7 @@ wxString CensusViewGridTable::GetTypeName(int row, int
col)
}
auto const& value = cell_at(row, col);
- auto const& conv = table_type_converter::get_by_value(value);
+ auto const& conv = table_type_converter::get(value);
return conv.grid_value_type(value);
}
- [lmi-commits] [lmi] master ba15191 11/46: Stop using wxRTTI in DatumSequenceEditorEvtHandler, (continued)
- [lmi-commits] [lmi] master ba15191 11/46: Stop using wxRTTI in DatumSequenceEditorEvtHandler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 5ee4b04 13/46: Improve comments in DatumSequenceEditorEvtHandler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 03d33ab 14/46: Make DatumSequenceEditorEvtHandler::entry_ const, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 0e2a694 16/46: Replace DatumSequenceEditorEvtHandler with a lambda, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 3e9f8af 02/46: Add census_view variant with wxGrid, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 804111d 04/46: Remove unnecessary use of std::swap(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 25a989e 10/46: Make table_type_converter::get_all() map const, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 12940dc 09/46: Define static map in more compact way, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master e1fdb77 12/46: Use Bind() in DatumSequenceEditorEvtHandler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 7e048d0 15/46: Remove apparently unnecessary wxEVT_CHAR handler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 7b62d49 21/46: Rename table_type_converter::get_by_value() to just get(),
Greg Chicares <=
- [lmi-commits] [lmi] master 1dacd5c 22/46: Move register_all() to table_custom_type_converter, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master a43eb0f 23/46: Add a comment explaining register_all() approach, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 4dcae52 34/46: Don't change default wxGrid lines colour, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 342b9f5 27/46: Always resize columns in CensusGridView::update_visible_columns(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master f217203 29/46: Rename "columns_count" to "old_columns_count" for consistency, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 395e268 41/46: Remove unnecessary calls to Update() when toggling autosize, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 713d56f 46/46: Fix defect introduced 20200608T2219Z: warning not suppressed, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 6281a6d 20/46: Make object returned by table_type_converter::get_impl() const, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master b85da3e 24/46: Clarify the comment about CensusViewDataViewModel wrappers, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 5423df7 25/46: Remove separate table_type_converter::type(), Greg Chicares, 2020/07/22