[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master f217203 29/46: Rename "columns_count" to "old
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master f217203 29/46: Rename "columns_count" to "old_columns_count" for consistency |
Date: |
Wed, 22 Jul 2020 11:05:14 -0400 (EDT) |
branch: master
commit f2172038afea3108549ceec79031e404f0f960c8
Author: Vadim Zeitlin <vadim@tt-solutions.com>
Commit: Vadim Zeitlin <vadim@tt-solutions.com>
Rename "columns_count" to "old_columns_count" for consistency
Similar variables for "rows" use "old" and "new" prefixes, so use them
for the columns too.
No real changes.
---
census_view.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/census_view.cpp b/census_view.cpp
index edc6e40..17e784f 100644
--- a/census_view.cpp
+++ b/census_view.cpp
@@ -2246,7 +2246,7 @@ void CensusGridView::update_visible_columns()
auto const cursor_row = grid_window_->GetGridCursorRow();
auto const cursor_col = grid_window_->GetGridCursorCol();
- auto const columns_count =
+ auto const old_columns_count =
lmi::ssize(grid_table_->get_visible_columns()) + 1;
auto const new_columns_count =
lmi::ssize(new_visible_columns) + 1;
@@ -2257,9 +2257,9 @@ void CensusGridView::update_visible_columns()
grid_table_->set_visible_columns(std::move(new_visible_columns));
- if(columns_count != new_columns_count)
+ if(old_columns_count != new_columns_count)
{
- grid_window_->DeleteCols(0, columns_count);
+ grid_window_->DeleteCols(0, old_columns_count);
grid_window_->AppendCols(new_columns_count);
grid_table_->make_cell_number_column_read_only();
}
- [lmi-commits] [lmi] master 804111d 04/46: Remove unnecessary use of std::swap(), (continued)
- [lmi-commits] [lmi] master 804111d 04/46: Remove unnecessary use of std::swap(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 25a989e 10/46: Make table_type_converter::get_all() map const, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 12940dc 09/46: Define static map in more compact way, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master e1fdb77 12/46: Use Bind() in DatumSequenceEditorEvtHandler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 7e048d0 15/46: Remove apparently unnecessary wxEVT_CHAR handler, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 7b62d49 21/46: Rename table_type_converter::get_by_value() to just get(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 1dacd5c 22/46: Move register_all() to table_custom_type_converter, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master a43eb0f 23/46: Add a comment explaining register_all() approach, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 4dcae52 34/46: Don't change default wxGrid lines colour, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 342b9f5 27/46: Always resize columns in CensusGridView::update_visible_columns(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master f217203 29/46: Rename "columns_count" to "old_columns_count" for consistency,
Greg Chicares <=
- [lmi-commits] [lmi] master 395e268 41/46: Remove unnecessary calls to Update() when toggling autosize, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 713d56f 46/46: Fix defect introduced 20200608T2219Z: warning not suppressed, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 6281a6d 20/46: Make object returned by table_type_converter::get_impl() const, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master b85da3e 24/46: Clarify the comment about CensusViewDataViewModel wrappers, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 5423df7 25/46: Remove separate table_type_converter::type(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master f82b136 31/46: Remove unnecessary make_cell_number_column_read_only() function, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 9f1cb2e 39/46: Only auto-size columns when they change, not after each update, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master b3ac65b 43/46: Allow wxGrid to compute census view column sizes more efficiently, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master ece93a0 17/46: Make check for Alt-Enter more obvious in the code, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master b57ed4a 18/46: Remove deleted DatumSequenceEditor copy-related methods, Greg Chicares, 2020/07/22