lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 7efa493 05/24: Resolve some marked defects [3


From: Greg Chicares
Subject: [lmi-commits] [lmi] master 7efa493 05/24: Resolve some marked defects [333]
Date: Wed, 30 Dec 2020 18:46:56 -0500 (EST)

branch: master
commit 7efa4932def7a555e8b1c47551a7ba39ba7e9001
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Resolve some marked defects [333]
    
    Worrying about a rogue process altering the x87 precision bits is not
    necessary for a server that, if ever deployed, won't use x87.
    
    Further refinements to server error reporting aren't warranted for a
    server that has no client aside from lmi's own GUI.
---
 ihs_server7702.cpp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/ihs_server7702.cpp b/ihs_server7702.cpp
index 07e6330..90be8f9 100644
--- a/ihs_server7702.cpp
+++ b/ihs_server7702.cpp
@@ -101,8 +101,9 @@ void Server7702::Process()
         }
     catch(server7702_precision_changed const& e)
         {
-        // TODO ?? Perhaps the control word should be changed and
-        // processing restarted.
+        // If an x87 build of a GPT server were to be released, then
+        // perhaps the control word should be changed and processing
+        // restarted.
         Output.Status |= precision_changed;
         warning() << Output.ContractNumber << " error: " << e.what() << 
LMI_FLUSH;
         }
@@ -185,7 +186,6 @@ void Server7702::PerformProcessing()
 
 //============================================================================
 // Other conditions are tested elsewhere.
-// TODO ?? We can add many similar conditions here.
 void Server7702::VerifyPlausibilityOfInput() const
 {
     if(Input.IssueAge.value() < 0)
@@ -285,7 +285,6 @@ void Server7702::ProcessNewIssue()
         &&  Input.OldDbo                    == Input.NewDbo
         ;
 
-    // TODO ?? It would be better to spell them all out.
     if(!okay)
         {
         throw server7702_inconsistent_input



reply via email to

[Prev in Thread] Current Thread [Next in Thread]