[lmi-commits] [lmi] master 53e98ab 13/24: Fix defect introduced 20100723T2339Z: wrong jurisdiction [326]

[Greg Chicares]

branch: master
commit 53e98ab11c0fc881511dee952dcd45c2399e54e0
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Fix defect introduced 20100723T2339Z: wrong jurisdiction [326]
    
    Commit f6a2418252 incorrectly added this line:
      StateOfJurisdiction_ = yare_input_.StateOfJurisdiction;
    The LHS had already correctly been initialized from a ctor argument.
    The RHS had a hardcoded default value that ignored that argument.
---
 ihs_basicval.cpp | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/ihs_basicval.cpp b/ihs_basicval.cpp
index 26cfb56..27faf92 100644
--- a/ihs_basicval.cpp
+++ b/ihs_basicval.cpp
@@ -131,6 +131,7 @@ BasicValues::BasicValues
     yare_input_.GroupUnderwritingType      = a_UnderwritingBasis  ;
     yare_input_.ProductName                = a_ProductName        ;
     yare_input_.PremiumTaxState            = a_StateOfJurisdiction;
+    yare_input_.StateOfJurisdiction        = a_StateOfJurisdiction;
     yare_input_.DefinitionOfLifeInsurance  = mce_gpt              ;
     yare_input_.DefinitionOfMaterialChange = mce_adjustment_event ;
 
@@ -268,12 +269,6 @@ void BasicValues::GPTServerInit()
     SetPermanentInvariants();
 
     StateOfDomicile_ = mc_state_from_string(product().datum("InsCoDomicile"));
-    // TODO ?? It seems that this assertion should fail sometimes,
-    // because StateOfJurisdiction_ is set from a ctor argument that
-    // may represent any state, but yare_input_.StateOfJurisdiction
-    // is not assigned that value above, and always retains its
-    // default value.
-    LMI_ASSERT_EQUAL(StateOfJurisdiction_, yare_input_.StateOfJurisdiction);
     StateOfJurisdiction_ = yare_input_.StateOfJurisdiction;
     PremiumTaxState_     = yare_input_.PremiumTaxState    ;