[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lmi] [PATCH] Weird fix for clang-7 build
From: |
Greg Chicares |
Subject: |
Re: [lmi] [PATCH] Weird fix for clang-7 build |
Date: |
Wed, 19 Jun 2019 00:50:19 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 2019-06-18 23:50, Vadim Zeitlin wrote:
[...]
> Hence the following patch is sufficient to resolve the problem:
Testing now. I'll probably be able to push it before hitting "Send".
> However several things are still unclear to me:
>
> - Where/how exactly are these symbols referenced?
> - Why does the problem only happen with clang and not gcc?
> - Why has it only started happening recently, when there hasn't been any
> changes involving multidimgrid_safe.tpp since many years. Perhaps it's
> due to clang version change, I could try building lmi with older clang to
> see if the problem happens with it too.
I've never understood that code. I'd much rather replace it than try
to understand it.
> What I'd like to know is whether you can just apply the trivial patch
> above so that lmi builds with clang out of the box
All tests succeeded. Pushing now.
> or if you'd like me to
> spend more time on the questions above to fully understand what's going on
> here?
No, that might be "mucho m??s arduo quetejer una cuerda de arena o que
amonedar el viento sin cara" as Borges put it.