lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi] [PATCH] Removing dependency on the external md5sum.exe


From: Vadim Zeitlin
Subject: [lmi] [PATCH] Removing dependency on the external md5sum.exe
Date: Wed, 19 Jun 2019 15:20:35 +0200

 Hello,

 Here is the long-promised PR removing the dependency on external md5sum
program, except during lmi build itself, when the standard system md5sum
utility is still used for checking the integrity of the downloads:

        https://github.com/vadz/lmi/pull/117

 I'm going to copy and paste the PR description here because I think/hope
it explains well what it does:

> This PR does 2 related things:
> 
> 1. Compute the file checksums and compare them with the expected values
> in lmi code itself, without using any external program at all.
> 2. Build native (i.e. without Cygwin dependencies) `lmi_md5sum.exe` for
> inclusion into the fardel distribution and, auxiliary, for the use in the
> unit tests (we can't use the system `md5sum` in them because this
> wouldn't work when running tests under Wine).
> 
> The third commit (adding the unit tests) could have been part of the
> first one, please feel free to squash them together if you'd like.
> 
> Finally, please note that we still use external md5sum program during lmi
> build, however this is not a problem, as we can just use the
> build-environment-native (i.e. Cygwin or Linux) utility in this case (but
> we can't include this binary in the fardel, which explains why we still
> need `lmi_md5sum.exe`).

 Because the PR does 2 things (but they are both done towards the same
goal, so I didn't think it was worth splitting it in 2 PRs), it's probably
better to review each commit separately (or, if you prefer, review commits
1+3 together and the second one separately).

 As always, please let me know if you have any questions about these
changes and, just FYI, this PR has been tested under both Cygwin and Linux.

 Thanks in advance for looking at this!
VZ

Attachment: pgp3NvME6FHV5.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]