[lwip-devel] [bug #56817] type of pbuf->type_internal too short

[Klaus Breining]

URL:
  <https://savannah.nongnu.org/bugs/?56817>

                 Summary: type of pbuf->type_internal too short
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: klaus_br
            Submitted on: Tue 27 Aug 2019 03:16:25 PM UTC
                Category: pbufs
                Severity: 3 - Normal
              Item Group: Compiler Warning
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: 2.1.1

    _______________________________________________________

Details:

In file: src/include/lwip/pbuf.h:

struct pbuf->type_internal should contain 
PBUF_TYPE_FLAG_* (mask: 0x00f0)
PBUF_TYPE_ALLOC_FLAG_* (mask: 0x0f00)
PBUF_TYPE_ALLOC_SRC_MASK (mask: 0x000f)

but the variable is defined as u8_t. On a TIARM compiler (and I guess also on
gcc) this results in a warning

#70-D integer conversion resulted in truncation.

The type should be u16_t instead. Otherwise it cannot be set to "PBUF_RAM" or
"PBUF_POOL"

I am using 2.1.2, which cannot be selected in the "lwIP version" field.




    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?56817>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/