[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: lynx-dev lynx2.8.2dev.18
From: |
Klaus Weide |
Subject: |
Re: lynx-dev lynx2.8.2dev.18 |
Date: |
Thu, 4 Mar 1999 17:08:23 -0600 (CST) |
On Thu, 4 Mar 1999, Greg Marr wrote:
> At 04:33 PM 3/4/99 , gil wrote:
> >>
> >It just broke on OS/390:
> >
> > ERROR CBC3275 ../../lynx2-8-2/src/LYKeymap.h:145
> > Unexpected text ',' encountered.
> > FSUM3065 The COMPILE step ended with return code 12.
> > FSUM3017 Could not compile ../../lynx2-8-2/src/LYMap.c.
> > Correct the errors and try again.
> > gmake[1]: *** [LYMap.o] Error 3
> >
> >Bummer. It's a comma between the enumerator-list and the "}".
> >ANSI seems not to allow this.
This seems hard to believe, but looking at other enums in the Lynx
code shows that they all avoid the final comma.
> > Sure makes ending an enumerator-list
> >inside an ifdef a pain. Since the list unconditionally begins with
> >LYK_UNKNOWN, the problem could be solved by writing all subsequent
> >entries with the comma in front of the enumerator. Ugly. But should
> >I try a patch?
>
> Another method that I've used is to put something like UNUSED just before the
> }.
> This requires the least amount of changes, and also doesn't break if the
> *first* item in the list gets #ifdef'ed out, or if the list gets sorted.
This style seems much preferable to me.
Klaus
- lynx-dev lynx2.8.2dev.19 patch #3 (non UNIX build), (continued)
- Re: lynx-dev lynx2.8.2dev.18, brian j pardy, 1999/03/04
- Re: lynx-dev lynx2.8.2dev.18, Kim DeVaughn, 1999/03/04
- Re: lynx-dev lynx2.8.2dev.18, pg, 1999/03/04
- Re: lynx-dev lynx2.8.2dev.18, dickey, 1999/03/04
- Re: lynx-dev lynx2.8.2dev.18, Kim DeVaughn, 1999/03/04
- Re: lynx-dev lynx2.8.2dev.18, pg, 1999/03/04
- Re: lynx-dev lynx2.8.2dev.18, dickey, 1999/03/04
- Re: lynx-dev lynx2.8.2dev.18, pg, 1999/03/04
- Re: lynx-dev lynx2.8.2dev.18, Greg Marr, 1999/03/04
- Re: lynx-dev lynx2.8.2dev.18,
Klaus Weide <=
- Re: lynx-dev lynx2.8.2dev.18, pg, 1999/03/04
- Re: lynx-dev lynx2.8.2dev.18, Kim DeVaughn, 1999/03/05
Re: lynx-dev lynx2.8.2dev.18, pg, 1999/03/04
Re: lynx-dev lynx2.8.2dev.18, pg, 1999/03/05