Re: lynx-dev lynx2.8.2dev.18

[pg]

In a recent note, address@hidden said:

> Date: Thu, 4 Mar 1999 17:07:33 -0500 (EST)
> 
> > It just broke on OS/390: 
> >     FSUM3017 Could not compile ../../lynx2-8-2/src/LYMap.c. 
> >  
I deem this a serious problem. No .o file.

> > entries with the comma in front of the enumerator.  Ugly.  But should 
> > I try a patch? 
> 
> sure (fortunately, the 0th element doesn't need ifdef's, ever).
> 
> If there's serious problems with it (such as not recognizing the syntax

Am I dealing with an anal-retentive compiler?  Sure.  But I enthusiastically
support it.  If compilers start tolerating sloppy C, programmers will start
coding sloppy C.  And we all know what happened when browsers started
tolerating sloppy HTML.  Do I agree with ANSI's choice of prohibiting
the trailing comma.  Not entirely.  But should trailing commas be
permitted everywhere, e.g. at the end of a parameter list of a function
call?

Patch attached.  Maximally violates Greg Marr's dictum of sortability,
editability, and general homogeneity of the list: I didn't move all
commas to the left of the object; I merely moved each comma at the
end of an ifdef'ed cluster to the front.  If Greg complains enough,
I'll rewrite it.  :-)

-- gil
==================================================
%%% Created Thu Mar  4 14:43:36 MST 1999 by target lynx.patch. %%%
diff -brc orig/lynx2-8-2/src/LYKeymap.h lynx2-8-2/src/LYKeymap.h
*** orig/lynx2-8-2/src/LYKeymap.h       Thu Mar  4 03:39:45 1999
--- lynx2-8-2/src/LYKeymap.h    Thu Mar  4 14:38:55 1999
***************
*** 118,148 ****
      LYK_CHANGE_LINK,
      LYK_EDIT_TEXTAREA,
      LYK_GROW_TEXTAREA,
!     LYK_INSERT_FILE,
  
  #ifdef EXP_ADDRLIST_PAGE
!     LYK_ADDRLIST,
  #else
  #define LYK_ADDRLIST      LYK_ADD_BOOKMARK
  #endif
  
  #ifdef USE_EXTERNALS
!     LYK_EXTERN,
  #endif /* !defined(USE_EXTERNALS) */
  
  #if defined(VMS) || defined(DIRED_SUPPORT)
!     LYK_DIRED_MENU,
  #else
  #define LYK_DIRED_MENU    LYK_UNKNOWN
  #endif /* VMS || DIRED_SUPPORT */
  
  #ifdef DIRED_SUPPORT
!     LYK_CREATE,
      LYK_REMOVE,
      LYK_MODIFY,
      LYK_TAG_LINK,
      LYK_UPLOAD,
!     LYK_INSTALL,
  #else
  #define LYK_TAG_LINK      LYK_UNKNOWN
  #endif /* DIRED_SUPPORT */
--- 118,148 ----
      LYK_CHANGE_LINK,
      LYK_EDIT_TEXTAREA,
      LYK_GROW_TEXTAREA,
!     LYK_INSERT_FILE
  
  #ifdef EXP_ADDRLIST_PAGE
!   , LYK_ADDRLIST
  #else
  #define LYK_ADDRLIST      LYK_ADD_BOOKMARK
  #endif
  
  #ifdef USE_EXTERNALS
!   , LYK_EXTERN
  #endif /* !defined(USE_EXTERNALS) */
  
  #if defined(VMS) || defined(DIRED_SUPPORT)
!   , LYK_DIRED_MENU
  #else
  #define LYK_DIRED_MENU    LYK_UNKNOWN
  #endif /* VMS || DIRED_SUPPORT */
  
  #ifdef DIRED_SUPPORT
!   , LYK_CREATE,
      LYK_REMOVE,
      LYK_MODIFY,
      LYK_TAG_LINK,
      LYK_UPLOAD,
!     LYK_INSTALL
  #else
  #define LYK_TAG_LINK      LYK_UNKNOWN
  #endif /* DIRED_SUPPORT */