[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MIT-Scheme-devel] [commit 18eca0a] Fixed compile-ffi to use run-she

From: Taylor R Campbell
Subject: Re: [MIT-Scheme-devel] [commit 18eca0a] Fixed compile-ffi to use run-shell-command.
Date: Wed, 27 Apr 2011 20:21:39 +0000
User-agent: IMAIL/1.21; Edwin/3.116; MIT-Scheme/9.1

   commit 18eca0a6b11b54b47390c7d2fe64453d5b8e3019
   Author: Matt Birkholz <address@hidden>
   Date:   Tue Apr 26 10:47:42 2011 -0700

   Fixed compile-ffi to use run-shell-command.

   Now sets the working directory and checks make's exit code.

   -     (run-synchronous-subprocess "make" '("compile-liarc-bundle"))))
   +     (let ((line "make compile-liarc-bundle"))
   +       (for-each display (list ";Running `"line"' in "dir"...\n"))
   +       (let ((code (run-shell-command line 'working-directory dir)))
   +         (if (not (zero? code))
   +             (error "Shell command exited with error code:" code))))))

You can set the working directory pathname just the same with
RUN-SYNCHRONOUS-SUBPROCESS.  I think it is better to use that rather
than RUN-SHELL-COMMAND, and in general to avoid involving any shells,
even if here the shell command is literally given and straightforward.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]