[Mldonkey-users] [patch #4977] vd html progress bars

[Dennis Nezic]

URL:
  <http://savannah.nongnu.org/patch/?func=detailitem&item_id=4977>

                 Summary: vd html progress bars
                 Project: mldonkey, a multi-networks file-sharing client
            Submitted by: dennisne
            Submitted on: Fri 03/17/06 at 06:28
                Category: Improved interfaces
                Priority: 6
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open

    _______________________________________________________

Details:

in mldonkey's web interface, a table with two cells was used to display
download progress (with widths corresponding to the completed and remaining
percentages). this patch simplifies the html by displaying progress as a
single HR element, left aligned. effectively, it will look almost exactly as
before, albeit the code will be cleaner.

BUT, the main purpose of this patch is to have the download progress bars
displayable when users have their browsers set to force their own colors (ie,
mine forces /all/ pages to have black backgrounds and gray text).
unfortunately, this eliminates all background-color style elements (bgcolors,
etc), which is what the previous table implementation was using (the bar was
the background color of the table cell). so, without this patch, i cannot see
the progress bar at all! using this method, the bar is an actual line, and
displays fine :)

and, did i mention it cleans up the code? it also eliminates the
color_vd_remaining style variable, which was pretty useless anyways, since it
was pretty much always the background color (ie, effectively transparent).

for users who force their own colors, this patch is essential -- and for
others, it makes no difference, besides simplifying the style a bit.
actually, the /only/ display difference is that the bar is rendered with
rounded edges here (in my firefox) ... which is a positive side-effect, i
think, since if a style declares a larger bar size, it becomes nice and
rounded -- very good looking (although, i prefer the small default of 2px).





    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Fri 03/17/06 at 06:28  Name: vd_completion_bar_hr.patch  Size: 8.84KB  
By: dennisne
replaces table with hr for download progress bar, applied against 2.7.4
release
<http://savannah.nongnu.org/patch/download.php?item_id=4977&item_file_id=6047>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?func=detailitem&item_id=4977>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/