Re: monit monitor.c monitor.h control.c

[Jan-Henrik Haukeland]

Rory Toma <address@hidden> writes:

> Log message:
>       Fix the "clobbering" of p->do_validate. It wasn't really getting
>       clobbered, rather, the second instance of monit was changing
>       it's structure, and the running monit's structure was not being
>       changed. We now pass this through cervlet.c so we change the
>       correct structure.

Good work! To bad I didn't have time to check this before since I
think I would have nailed it pretty fast since I think this is more or
less aligned with the original logic I used in version <= 3.0.

Just a thought, if you move the code

+      if( exist_daemon() ) {
+       d_check_process(P, "stop");

into check_process and do the test there you could save some space in
monitor.c:do_action :-) 

-- 
Jan-Henrik Haukeland