[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fixed: calculation of mouse click position in get_mouseinput
|
From: |
Benno Schulenberg |
|
Subject: |
Re: [PATCH] fixed: calculation of mouse click position in get_mouseinput() |
|
Date: |
Mon, 21 Dec 2020 19:47:18 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
Op 20-12-2020 om 08:30 schreef ObeliX:
> Subject: [PATCH] fixed: calculation of mouse click position in
> get_mouseinput()
>
> mouse click position was shifted by current margin value (space occupied by
> line number and marker column), even when click happened in bottom window's
> shortcut listing area.
Indeed. Thanks for finding that. I've re-reported the issue here:
https://savannah.gnu.org/bugs/?59749
> also the returned coordinates by this function were quite a mess. [...]
Your patch mixes a bug fix with some refactoring. That is not a good idea.
Please provide a patch that fixes only the bug. When all is to my liking
and it has been merged, then we can have a look at improving the code.
(Also note: after an 'if' always a space, and the statements after 'if' and
'else' never on the same line.)
Benno
signature.asc
Description: OpenPGP digital signature