[Octave-bug-tracker] [bug #46521] [octave forge] (communications) fails to build with latest stable octave

[Markus Mützel]

Follow-up Comment #46, bug #46521 (project octave):

After merging the changes from the remote repository (hg id ), I still have
the following local changes:

diff -r 47e4a4bdb477 src/gf.cc
--- a/src/gf.cc Fri Dec 20 18:39:25 2019 -0500
+++ b/src/gf.cc Sun Dec 22 14:06:51 2019 +0100
@@ -622,7 +621,7 @@
     }
   if (si.numel () != ab_len - 1)
     {
-      error ("gfilter: si must be a vector of length max(length(a),
length(b)) - 1");
+      error ("gfilter: si must be a vector of length max(numel(a), numel(b))
- 1");
       return galois ();
     }
   if (norm != 1)
@@ -752,7 +751,7 @@
 @smallexample\n\
 @group\n\
    N                   M\n\
-  SUM a(k+1) y(n-k) = SUM b(k+1) x(n-k)      for 1<=n<=length(x)\n\
+  SUM a(k+1) y(n-k) = SUM b(k+1) x(n-k)      for 1<=n<=numel(x)\n\
   k=0                 k=0\n\
 @end group\n\
 @end smallexample\n\
@@ -764,7 +763,7 @@
  $a \\in \\Re^{N-1}$, $b \\in \\Re^{M-1}$, and $x \\in \\Re^P$.\n\
 @end tex\n\
 @ifnottex\n\
- N=length(a)-1 and M=length(b)-1.\n\
+ N=numel(a)-1 and M=numel(b)-1.\n\
 @end ifnottex\n\
 An equivalent form of this equation is:\n\
 @tex\n\
@@ -778,7 +777,7 @@
 @smallexample\n\
 @group\n\
             N                   M\n\
-  y(n) = - SUM c(k+1) y(n-k) + SUM d(k+1) x(n-k)  for 1<=n<=length(x)\n\
+  y(n) = - SUM c(k+1) y(n-k) + SUM d(k+1) x(n-k)  for 1<=n<=numel(x)\n\
            k=1                 k=0\n\
 @end group\n\
 @end smallexample\n\
diff -r 47e4a4bdb477 src/ov-galois.h
--- a/src/ov-galois.h   Fri Dec 20 18:39:25 2019 -0500
+++ b/src/ov-galois.h   Sun Dec 22 14:06:51 2019 +0100
@@ -103,7 +103,7 @@
 
   bool is_defined (void) const { return true; }
 
-  bool is_numeric_type (void) const { return true; }
+  bool isnumeric (void) const { return true; }
 
   bool is_constant (void) const { return true; }
 
@@ -127,7 +127,7 @@
 
   bool is_real_matrix (void) const { return false; }
 
-  bool is_real_type (void) const { return false; }
+  bool isreal (void) const { return false; }
 
   // FIXME
   bool valid_as_scalar_index (void) const { return false; }


I think at least the changes in ov-galois.h still need to be handled. Maybe
with the OV_ISNUMERIC and OV_ISREAL macros.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?46521>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/