[Octave-bug-tracker] [bug #65342] replace atoi with stoi

[Rik]

Update of bug#65342 (group octave):

                Category:         Octave Function => Coding Style and
Maintenance
                Severity:              3 - Normal => 1 - Wish               
                Priority:              5 - Normal => 4                      
                  Status:                    None => Confirmed              
        Operating System:               GNU/Linux => Any                    
         Planned Release:                    None => 10.1.0 (current default)

    _______________________________________________________

Follow-up Comment #1:

This would be a good idea and a fairly simple replacement.  Can you prepare a
changeset or patch for this?  There are only 19 instances of atoi in the
entire Octave codebase.  See below and in the attached file atoi.lst


libinterp/corefcn/debug.cc:643:            start = atoi (start_str.c_str ());
libinterp/corefcn/debug.cc:647:              end = atoi (end_str.c_str ());
libinterp/corefcn/debug.cc:657:            int line = atoi (arg.c_str ());
libinterp/corefcn/debug.cc:685:            start = atoi (start_str.c_str ());
libinterp/corefcn/debug.cc:689:              end = atoi (end_str.c_str ());
libinterp/corefcn/debug.cc:693:            start = atoi (arg.c_str ());
libinterp/corefcn/debug.cc:754:          n = atoi (s_arg.c_str ());
libinterp/corefcn/debug.cc:801:              n = atoi (s_arg.c_str ());
libinterp/corefcn/debug.cc:950:          n = atoi (s_arg.c_str ());
libinterp/corefcn/debug.cc:1041:          n = atoi (arg.c_str ());
libinterp/corefcn/event-manager.cc:365:                retval(idx++) = atoi
(str.c_str ());
libinterp/corefcn/event-manager.cc:380:      retval = ovl (items, *it++, atoi
(it->c_str ()));
libinterp/dldfcn/__init_fltk__.cc:606:                    val = atoi
(valstr.c_str ());
libinterp/parse-tree/bp-table.cc:389:          else if (atoi
(args(pos).string_value ().c_str ()) > 0)
libinterp/parse-tree/bp-table.cc:434:              if (atoi (arg.c_str ()) ==
0)
libinterp/parse-tree/bp-table.cc:461:                  int line = atoi
(args(pos).string_value ().c_str ());
liboctave/util/data-conv.cc:394:              block_size = atoi (s.c_str ());
liboctave/util/data-conv.cc:461:          block_size = atoi (s.c_str ());
liboctave/util/pathsearch.cc:114:        kpse_debug |= atoi (val.c_str ());



(file #55731)

    _______________________________________________________

Additional Item Attachment:

File name: atoi.lst                       Size:1 KB
    <https://file.savannah.gnu.org/file/atoi.lst?file_id=55731>


    AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://git.savannah.nongnu.org/cgit/administration/savane.git/snapshot/savane-24d3702d7a77e2ff4eb0f39b986d772d82c134fd.tar.gz


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65342>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/