[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #61753] Changing assert to panic_impossible
From: |
John W. Eaton |
Subject: |
[Octave-bug-tracker] [bug #61753] Changing assert to panic_impossible |
Date: |
Sat, 23 Mar 2024 14:17:59 -0400 (EDT) |
Update of bug #61753 (group octave):
Planned Release: None => 10.1.0 (current default)
_______________________________________________________
Follow-up Comment #20:
The following changesets eliminate the last uses of assert in libinterp
files:
https://hg.savannah.gnu.org/hgweb/octave/rev/432e0151f652
https://hg.savannah.gnu.org/hgweb/octave/rev/08ab46f6e241
Is there anything left to do for this bug report? Maybe there are still some
places were we could use error instead of panic?
Did you intend to also try to eliminate the uses of assert in liboctave? I
thought about moving the panic functions to liboctave, but they ultimately
call error_system::vpanic. Moving that to liboctave might not be possible.
There do seem to be some overly aggressive uses of assert in the argument
validation of various liboctave functions, so maybe we should look to convert
those to call error instead? I count a total of 50 remaining uses of assert
in liboctave. I could start to look at some of those now.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?61753>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #61753] Changing assert to panic_impossible,
John W. Eaton <=
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- Message not available
- [Octave-bug-tracker] [bug #61753] Changing assert to panic_impossible, Rik, 2024/03/23