[Octave-bug-tracker] [bug #65644] jupyter-notebook tests fail if a figure is already open

[Nicholas Jankowski]

Follow-up Comment #5, bug #65644 (group octave):

looks like the intent of that code is to:

1 - check for existing figs, capture their fig numbers in fig_ids
2 - create a new blank fig at # n+1
3 - run whatever plotting code is in `__code__`
4 - check if the new black fig was used or not *the failing get*
5 - if so, delete it
6 - check remaining figures against fig_ids and delete anything new.
7 - lots of manual cleanup actions to remove tempfiles. 


simply removing the 'close all hidden' line avoids the error, and test
jupyter-notebook.tst passes whether or not an existing figure window is
present.  

it seems as long as the eval'd code doesn't close the new figure the rest of
the code runs without issue. e.g., putting a close(gcf) at the end of the code
snippet causes the same error (as that closes the newFig figure), but a
close(1) closing the existing window but leaving the newFig figure runs
without error.

I'm not familiar enough with jupyter_notebook() to know how arbitrary code
needs to be permitted to be.  probably we could add an ishandle(newFig) check
to that conditional before the get(newFig) check. i'll play with that a bit.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65644>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/