[Octave-bug-tracker] [bug #65644] jupyter-notebook tests fail if a figure is already open

[Nicholas Jankowski]

Update of bug #65644 (group octave):

                  Status:               Confirmed => Patch Submitted        
           Fixed Release:                    None => 9.2.0 (current stable) 

    _______________________________________________________

Follow-up Comment #6:

confirming that simply changing 

    if (exist ("newFig") && isempty (get (newFig, "children")))



    if (exist ("newFig") && ishandle (newFig) && isempty (get (newFig,
"children")))


eliminates the error if newFig is closed by the eval'd code.

since newFig is supposed to hold any test figures created, there's no good
reason for a 'close all hidden' line in the test code, even though it no
longer errors.  to avoid inadvertently closing existing figures when running
the test, we should remove that line. it doesn't seem to cause any problems.

the attached patch makes those changes against stable.

there's also a FIXME note that much of the cleanup should be placed inside a
unwind_protect/ cleanup  block so it gets run on an error.  e.g., i noticed
the subject error kept figures set to default visibility off and left that
unrestored. I haven't done that, but it would probably be worth doing.

marking as patch sumbitted.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65644>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/