Re: linking liboctave fails (lapack missing?)

[Benjamin Lindner]

Benjamin Lindner wrote:
> Benjamin Lindner wrote:
> > Hello,
> >
> > I just tried to build the recent development tip on mingw32 and 
> > building fails at linking liboctave with a phletora of missing symbols 
> > from the lapack library.
> >
> > looking at the linker command I see that indeed there is no -llapack 
> > present.
> >
> > Digging the changelog I find that at revision 9490:3aeb7d881578
> > $(BLAS_LIBS) has been removed from LINK_DEPS in liboctave/makefile.in
> >
> > I guess it should still be there, since arpack, qrupdate and quite 
> > some octave code depends on it.
>
> I see that there is already a thread covering this topic on the bugs 
> list. Sorry for the double-post.
>
> Hovever, liboctave directly uses functinos from lapack, and uses the 
> qrupdate and qrpack library which both depend on lapack, so lapack 
> *should* be listed in LINK_DEPS.

The attached changeset fixes the linker issues for mingw32 platform by 
adding $(BLAS_LIBS) in liboctave's link depencendies.

benjamin

# HG changeset patch
# User Benjamin Lindner <address@hidden>
# Date 1250195832 -7200
# Node ID c8c7b48e2cf4ddbf29dbec62003a66abfa7103bd
# Parent  54055478b3bb512107fe558a11f822fca76cd972
add BLAS_LIBS to liboctave's LINK_DEPS

diff -r 54055478b3bb -r c8c7b48e2cf4 liboctave/ChangeLog
--- a/liboctave/ChangeLog       Thu Aug 13 20:58:28 2009 +0200
+++ b/liboctave/ChangeLog       Thu Aug 13 22:37:12 2009 +0200
@@ -1,3 +1,7 @@
+2009-08-13  Benjamin Lindner <address@hidden>
+
+       * Makefile.in: Include $(BLAS_LIBS) in liboctave's link depencendies
+
 2009-08-12  Jaroslav Hajek  <address@hidden>
 
        * Makefile.in: Include LDFLAGS when linking shared executable.
diff -r 54055478b3bb -r c8c7b48e2cf4 liboctave/Makefile.in
--- a/liboctave/Makefile.in     Thu Aug 13 20:58:28 2009 +0200
+++ b/liboctave/Makefile.in     Thu Aug 13 22:37:12 2009 +0200
@@ -39,7 +39,7 @@
   -L../libcruft $(LIBCRUFT) \
   $(CHOLMOD_LIBS) $(UMFPACK_LIBS) $(AMD_LIBS) $(CAMD_LIBS) \
   $(COLAMD_LIBS) $(CCOLAMD_LIBS) $(CXSPARSE_LIBS) $(ARPACK_LIBS) \
-  $(QRUPDATE_LIBS) $(FFTW_LIBS) $(READLINE_LIBS) $(TERM_LIBS) $(LIBGLOB) \
+  $(QRUPDATE_LIBS) $(BLAS_LIBS) $(FFTW_LIBS) $(READLINE_LIBS) $(TERM_LIBS) 
$(LIBGLOB) \
   $(REGEX_LIBS) $(DL_LIBS) $(LIBS) $(FLIBS) $(PTHREAD_LIBS)
 
 MATRIX_INC := Array.h Array2.h Array3.h ArrayN.h DiagArray2.h \