octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Octave line length


From: John W. Eaton
Subject: Re: Octave line length
Date: Tue, 14 Jan 2020 11:32:55 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0

On 1/14/20 11:25 AM, Rik wrote:

I don't know how to do it with a reformatting tool, but with Perl it was
easy enough.

How?  I'd like to take a look at some of the long lines you found.

The extremely long line lengths (> 200) should probably be checked and
dealt with.  I looked at one instance just to get an idea and it was

       return 0.11380523107427108222e0 + (0.43099572287871821013e-2 +
(0.36544324341565929930e-4 + (0.47965044028581857764e-6 +
(0.81819034238463698796e-8 + (0.17934133239549647357e-9 +
(0.50956666166186293627e-11 + (0.18850487318190638010e-12 +
0.79697813173519853340e-14 * t) * t) * t) * t) * t) * t) * t) * t;

This could easily be split, but it is in the file Faddeeva.cc which we
specifically do *not* use Octave coding conventions in so that we can more
easily merge changes from upstream.

Yes, long initializer lists and pure arithmetic expressions like this probably aren't really the problem.

I think trying something like 95 might be a good first step.

Not 132, like old line printer output?

There is a histogram of developers as well.  I just don't imagine the
number who can *only* view 80 columns at a time is very large.

True, and terminal emulators wrap lines, don't they?

jwe





reply via email to

[Prev in Thread] Current Thread [Next in Thread]