octave-patch-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #9606] [octave forge] (image) New function


From: Hartmut
Subject: [Octave-patch-tracker] [patch #9606] [octave forge] (image) New function integralImage
Date: Sun, 11 Aug 2019 10:53:14 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Follow-up Comment #13, patch #9606 (project octave):

I have had a look at the V5 version of comment #12.

* The execution time for the "rotated" version seems much better now. Here is
what I tested:
** tic; I = magic(5000); J=integralImage(I); toc
*** Online-Matlab: 0.35s
*** Octave V5 version: 0.67s
** tic; I = magic(5000); J=integralImage(I, 'rotated'); toc
*** Online-Matlab: 1.19s (=3.4 times slower as "upright")
*** Octave V5 version: 2.17s (=3.2 times slower as "upright")
* The copyright notice is still from 2018. Maybe change it to 2019?
* In the new test cases, there a some spaces missing in function calls of
magic and integralImage. (I know, those missing spaces are from my example
code... Sorry)

My conlcusion: I suggest to include this V5 version fully into the image
package. Including the "rotated" option, and without any warnings in the help
texts, now. It is now reasonably fast on usable images sizes (25Mpix in the
example above).

Thanks for this code improvement, Avinoam.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9606>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]