[Octave-patch-tracker] [patch #10021] [octave forge] (mapping) meridianfwd

[Philip Nienhuis]

Follow-up Comment #14, patch #10021 (project octave):

Sorry I have little time to spend on it.
A quick scan w.r.t. sph_chk.m:
* I like the idea vert much, could help reduce a lot of code duplication in
the referenceEllipsoid/-Spheroid/whatever functions.
* The 1st elseif clause (isstruct...): not just check struct but also if it is
a valid spheroid/ellipsoidstruct as well, by checking field names and class of
field contents. My thought is that anything which passes sph_chk.m will be fed
blindly to the functions calling it and those must rely on valid contents of
output 'E'; otherwise users will get errors they might be able not relate to
their input.
* Shouldn't the last 'else' be an elseif checking for char input (name of
ellipsoid)? Then there should be another 'else' withan error message


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10021>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/