[Octave-patch-tracker] [patch #10278] GSoC 2022: add support for sparse computations in ode15{i, s} using Octave classes , making dependency on KLU optional.

[Sarrah Bastawala]

Follow-up Comment #12, patch #10278 (project octave):


[comment #8 comment #8:]
> Afaict, SUNDIALS_EXPORT is defined like this in the headers:
 
Thank you for looking into that. As I was working on a Linux OS, to me it is
defined as follows in the headers : 


#ifdef SUNDIALS_STATIC_DEFINE
#  define SUNDIALS_EXPORT
#  define SUNDIALS_NO_EXPORT
#else
#  ifndef SUNDIALS_EXPORT
#    ifdef sundials_generic_EXPORTS
        /* We are building this library */
#      define SUNDIALS_EXPORT __attribute__((visibility("default")))
#    else
        /* We are using this library */
#      define SUNDIALS_EXPORT __attribute__((visibility("default")))
#    endif
#  endif

#  ifndef SUNDIALS_NO_EXPORT
#    define SUNDIALS_NO_EXPORT __attribute__((visibility("hidden")))
#  endif
#endif


This too dealt with permissions to expose code outside of a shared library. 

> Using it like this for functions exported from a library in Octave is
wrong.
> Remove it everywhere you used it.

As the current code is being written and used within Octave itself, and the
functions are used in pointers, I think you are correct in saying the EXPORT
macro should not be used. I have removed it and changes should reflect in the
next commit.  


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10278>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/