[Octave-patch-tracker] [patch #10278] GSoC 2022: add support for sparse computations in ode15{i, s} using Octave classes , making dependency on KLU optional.

[Markus Mützel]

Follow-up Comment #14, patch #10278 (project octave):

> As the current code is being written and used within Octave itself, and the
functions are used in pointers, I think you are correct in saying the EXPORT
macro should not be used. I have removed it and changes should reflect in the
next commit.

Well, if we ever wanted to build with MSVC on Windows, we'd need to define our
own `OCT_SUNDIALS_API` macro with those `dllimport` and `dllexport`
attributes. But I don't know of anyone is trying to do that. And we don't
*need* to do that for Linux or MinGW (if we don't mind that all symbols are
exported - as we currently do for all .oct libraries).



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?10278>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/