|
From: | Markus Mützel |
Subject: | [Octave-patch-tracker] [patch #10278] GSoC 2022: add support for sparse computations in ode15{i, s} using Octave classes , making dependency on KLU optional. |
Date: | Tue, 7 Mar 2023 07:27:02 -0500 (EST) |
Follow-up Comment #24, patch #10278 (project octave): Keeping the implementation in two separate files is probably ok. In that case, it is probably also ok to have a separate header in which the new functions are declared. But instead of special casing in `config-module.awk`, could you try the following change? diff -r 96ed8d1d0c59 libinterp/dldfcn/module-files --- a/libinterp/dldfcn/module-files Sat Mar 04 00:59:48 2023 -0500 +++ b/libinterp/dldfcn/module-files Tue Mar 07 13:25:39 2023 +0100 @@ -4,7 +4,7 @@ __glpk__.cc|$(GLPK_CPPFLAGS)|$(GLPK_LDFLAGS)|$(GLPK_LIBS) __init_fltk__.cc|$(FLTK_CPPFLAGS) $(FT2_CPPFLAGS) $(FONTCONFIG_CPPFLAGS)|$(FLTK_LDFLAGS) $(FT2_LDFLAGS)|$(FLTK_LIBS) $(FT2_LIBS) $(OPENGL_LIBS) __init_gnuplot__.cc|$(FT2_CPPFLAGS) $(FONTCONFIG_CPPFLAGS)|| -__ode15__.cc|$(SUNDIALS_XCPPFLAGS)|$(SUNDIALS_XLDFLAGS)|$(SUNDIALS_XLIBS) +__ode15__.cc oct-sundials.cc|$(SUNDIALS_XCPPFLAGS)|$(SUNDIALS_XLDFLAGS)|$(SUNDIALS_XLIBS) __voronoi__.cc|$(QHULL_CPPFLAGS)|$(QHULL_LDFLAGS)|$(QHULL_LIBS) audiodevinfo.cc|$(PORTAUDIO_CPPFLAGS)|$(PORTAUDIO_LDFLAGS)|$(PORTAUDIO_LIBS) audioread.cc|$(SNDFILE_CPPFLAGS)|$(SNDFILE_LDFLAGS)|$(SNDFILE_LIBS) That might still need some tinkering in `config-module.awk`. But it would be a more general solution if we'd get that to work. _______________________________________________________ Reply to this item at: <https://savannah.gnu.org/patch/?10278> _______________________________________________ Message sent via Savannah https://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |