Re: [Openvortex-dev] New patch. (obeying the rule "update often"...)

[O.Sezer]

Hi Manuel:

Manuel Jander wrote:
> Hi,
>
> I backported some few things from the unstable branch into the stable
> and merged them into the patch:
>
> http://galadriel.mat.utfsm.cl/~mjander/aureal/alsa/aureal-alsakernel2.patch.gz
>
> Best Regards
>
> Manuel

Is the attached patch (especially the first part) still relevant
if I apply this to alsa-1.0.2c ?

Thanks;
Özkan Sezer

http://cvs.sourceforge.net/viewcvs.py/alsa/alsa-driver/pci/au88x0/au88x0.c?r1=1.6&r2=1.7&sortby=date&diff_format=u
* fixed the DMA allocation.
  pci_set_dma_mask() is called together with pci_set_consistent_dma_mask().
  also clean up the double check of mask.
http://cvs.sourceforge.net/viewcvs.py/alsa/alsa-driver/pci/au88x0/au88x0.c?r1=1.8&r2=1.9&sortby=date&diff_format=u
* added snd_card_set_dev() macro.
* sysfsfied more pci, isapnp and usb drivers.

--- alsa-driver-1.0.2c/alsa-kernel/pci/au88x0/au88x0.c.orig
+++ alsa-driver-1.0.2c/alsa-kernel/pci/au88x0/au88x0.c
@@ -178,11 +178,11 @@
        // check PCI availability (DMA).
        if ((err = pci_enable_device(pci)) < 0)
                return err;
-       if (!pci_dma_supported(pci, VORTEX_DMA_MASK)) {
+       if (pci_set_dma_mask(pci, VORTEX_DMA_MASK) < 0 ||
+               pci_set_consistent_dma_mask(pci, VORTEX_DMA_MASK) << 0) {
                printk(KERN_ERR "error to set DMA mask\n");
                return -ENXIO;
        }
-       pci_set_dma_mask(pci, VORTEX_DMA_MASK);
 
        chip = snd_magic_kcalloc(vortex_t, 0, GFP_KERNEL);
        if (chip == NULL)
@@ -241,6 +241,8 @@
                goto alloc_out;
        }
 
+       snd_card_set_dev(card, &pci->dev);
+
        *rchip = chip;
 
        return 0;


http://cvs.sourceforge.net/viewcvs.py/alsa/alsa-driver/pci/au88x0/au88x0.c?r1=1.7&r2=1.8&sortby=date&diff_format=u
* This will fix a problem with undeclared PCI_DEVICE_ID_VIA_8365_1
--- alsa-driver-1.0.2c/alsa-kernel/pci/au88x0/au88x0.c.orig
+++ alsa-driver-1.0.2c/alsa-kernel/pci/au88x0/au88x0.c
@@ -65,6 +65,13 @@
 MODULE_DEVICES
     ("{{Aureal Semiconductor Inc., Aureal Vortex Sound Processor}}");
 
+#ifndef PCI_VENDOR_ID_VIA 
+#define PCI_VENDOR_ID_VIA 0x1106
+#endif
+#ifndef PCI_DEVICE_ID_VIA_8365_1
+#define PCI_DEVICE_ID_VIA_8365_1 0x8305
+#endif
+
 #ifndef MODULE
 
 static int __init alsa_card_vortex_setup(char *str)