Re: [Pan-users] pan >= 0.100 fail to compile with gcc 3.2.3 (needs iostream in general/string-view.h)

[Charles Kerr]

Christian Lohmaier wrote:
> Hi Charles, *,
>
> pan 0.100 and newer fail to compile with gcc 3.2.3 because of the change
> in pan/general/string-view.h (now includes iosfwd instead of iostream)
>
> It fails with:
> if g++ -DHAVE_CONFIG_H -I. -I. -I../..  -I../.. -I/usr/include/gmime-2.0
> -I/opt/gnome2/include/glib-2.0 -I/opt/gnome2/lib/glib-2.0/include
> -I/opt/gnome2/include/glib-2.0 -I/opt/gnome2/lib/glib-2.0/include
> -march=athlon-xp -m3dnow -msse -mfpmath=sse -mmmx -O3 -pipe -fforce-addr
> -fomit-frame-pointer -frerun-cse-after-loop -frerun-loop-opt
> -falign-functions=4 -maccumulate-outgoing-args -fpic -g -MT url-find.o -MD -MP
> -MF ".deps/url-find.Tpo" -c -o url-find.o url-find.cc; \
> then mv -f ".deps/url-find.Tpo" ".deps/url-find.Po"; else rm -f
> ".deps/url-find.Tpo"; exit 1; fi
> url-find.cc: In function `bool pan::url_find(const pan::StringView&,
>    pan::StringView&)':
> url-find.cc:50: `isalpha' undeclared (first use this function)
> url-find.cc:50: (Each undeclared identifier is reported only once for each
>    function it appears in.)
> url-find.cc:60: `isspace' undeclared (first use this function)
> make[3]: *** [url-find.o] Fehler 1
> make[3]: Verlassen des Verzeichnisses Verzeichnis 
> »/home/cl/rpmbuild/BUILD/pan-0.103/pan/usenet-utils«
> make[2]: *** [all-recursive] Fehler 1
> make[2]: Verlassen des Verzeichnisses Verzeichnis 
> »/home/cl/rpmbuild/BUILD/pan-0.103/pan«
> make[1]: *** [all-recursive] Fehler 1
> make[1]: Verlassen des Verzeichnisses Verzeichnis 
> »/home/cl/rpmbuild/BUILD/pan-0.103«
> make: *** [all] Fehler 2
> Fehler: Bad exit status from /var/tmp/rpm-tmp.5232 (%build)
>
>
> Adding #include <iostream> back to pan/general/string-view.h allows it
> to compile.

Hi Christian,

Instead of adding #include <iostream> to pan/general/string-view.h,
does adding #include <cctype> to url-find.cc fix it?  IMO that would
be the cleaner change.

Charles