[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch 0/7] some bits of simpler-proc ready for review
From: |
John Darrington |
Subject: |
Re: [patch 0/7] some bits of simpler-proc ready for review |
Date: |
Sun, 3 Jun 2007 16:13:45 +0800 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
I would suggest that we try merging in bigger chunks. If each patch
is going to be as small as these, then it'll take a long time. Maybe
try it on a per directory basis. For example Smake, configure.ac and
Makefile.am I think could be merged immediately. Probably everything
in libpspp too. If a patch proves to be controversial, then it can be
split into smaller ones.
In so far as these patches go, the only concern I have is removing the
next/prev/up pointers from the documentation. It will make the manual
harder to navigate.
Last week I had a look at the other things that need to be merged. One
mental note I made was that math/ordering.[ch] ought to be moved to
data --- it results in circular dependencies being in math, and it
pertains to data definition/semantics so probably makes more sense in
src/data
J'
On Sat, Jun 02, 2007 at 03:36:47PM -0700, address@hidden wrote:
I've isolated a few of the more trivial changes I made in the simpler-proc
branch for review. I'm mailing them to pspp-dev using the "quilt mail"
interface, as an experiment. If this turns out to be too awkward or
annoying,
I'll send the rest of the review requests some other way.
I'm hoping to have the substantive parts of simpler-proc ready for review
later today or tomorrow.
--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.
signature.asc
Description: Digital signature
- [patch 0/7] some bits of simpler-proc ready for review, blp, 2007/06/03
- [patch 2/7] Add insert_range, insert_element functions., blp, 2007/06/03
- [patch 7/7] Implement support for "INTEGER LIST"-type subcommands in q2c. The documentation claimed these were supported, but actually they werent., blp, 2007/06/03
- [patch 5/7] Remove author. Fix compile-command., blp, 2007/06/03
- [patch 6/7] Use var_is_alpha., blp, 2007/06/03
- [patch 4/7] Remove next, prev, up node names from @node lines, to make structural changes to the manual easier. (These node names are not needed by makeinfo.), blp, 2007/06/03
- [patch 3/7] Ignore _ndebug, _profile directories that I use for -DNDEBUG and profiling builds., blp, 2007/06/03
- [patch 1/7] Insert some missing "#include <config.h>" lines., blp, 2007/06/03
- Re: [patch 0/7] some bits of simpler-proc ready for review,
John Darrington <=