[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch 0/7] some bits of simpler-proc ready for review
From: |
Ben Pfaff |
Subject: |
Re: [patch 0/7] some bits of simpler-proc ready for review |
Date: |
Sun, 03 Jun 2007 08:31:23 -0700 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) |
John Darrington <address@hidden> writes:
> I would suggest that we try merging in bigger chunks. If each patch
> is going to be as small as these, then it'll take a long time. Maybe
> try it on a per directory basis. For example Smake, configure.ac and
> Makefile.am I think could be merged immediately. Probably everything
> in libpspp too. If a patch proves to be controversial, then it can be
> split into smaller ones.
This is just the odds and ends. Most of the rest will be bigger
pieces.
> In so far as these patches go, the only concern I have is removing the
> next/prev/up pointers from the documentation. It will make the manual
> harder to navigate.
Removing the pointers from the documentation has no effect on the
.info file, because the makeinfo program is smart enough to
reconstruct the pointers. It just makes it easier to maintain
the Texinfo files, because now you can move around nodes without
having to update any next/prev/up pointers (either by hand or
with Emacs assistance).
> Last week I had a look at the other things that need to be merged. One
> mental note I made was that math/ordering.[ch] ought to be moved to
> data --- it results in circular dependencies being in math, and it
> pertains to data definition/semantics so probably makes more sense in
> src/data
Yes I agree.
--
"...I've forgotten where I was going with this,
but you can bet it was scathing."
--DesiredUsername
- [patch 0/7] some bits of simpler-proc ready for review, blp, 2007/06/03
- [patch 2/7] Add insert_range, insert_element functions., blp, 2007/06/03
- [patch 7/7] Implement support for "INTEGER LIST"-type subcommands in q2c. The documentation claimed these were supported, but actually they werent., blp, 2007/06/03
- [patch 5/7] Remove author. Fix compile-command., blp, 2007/06/03
- [patch 6/7] Use var_is_alpha., blp, 2007/06/03
- [patch 4/7] Remove next, prev, up node names from @node lines, to make structural changes to the manual easier. (These node names are not needed by makeinfo.), blp, 2007/06/03
- [patch 3/7] Ignore _ndebug, _profile directories that I use for -DNDEBUG and profiling builds., blp, 2007/06/03
- [patch 1/7] Insert some missing "#include <config.h>" lines., blp, 2007/06/03
- Re: [patch 0/7] some bits of simpler-proc ready for review, John Darrington, 2007/06/03
- Re: [patch 0/7] some bits of simpler-proc ready for review,
Ben Pfaff <=