Re: Datasheet internals

[John Darrington]

Gtk is supposed to treat hypens and underscores identically in signal
names, so long as you don't mix and match them in the same string.
But I'm trying to standardise on hyphens so it'd be a good idea to
check in your patch.

J'

On Wed, Jun 13, 2007 at 09:55:05PM -0700, Ben Pfaff wrote:

     But then it'll just assert at the case_data_rw call in the for
     loop a few lines farther down.  This is because val_cnt shouldn't
     be zero: it should be 1 if you added a new numeric or short
     string variable.  But the column isn't getting added to the
     datasheet.  Why?  The callback isn't getting fired.  Why?  One
     reason is a misspelling, I think: the code isn't sure whether the
     callbacks are named with underscores or hyphens.  The following
     patch helps a bit:
     
     --- gui.orig/src/ui/gui/psppire-dict.c     2007-06-13 21:45:02.000000000 
-0700
     +++ gui/src/ui/gui/psppire-dict.c  2007-06-13 21:45:16.000000000 -0700
     @@ -110,7 +110,7 @@
        object_class->finalize = psppire_dict_finalize;
      
        signals [VARIABLE_CHANGED] =
     -    g_signal_new ("variable_changed",
     +    g_signal_new ("variable-changed",
                  G_TYPE_FROM_CLASS (class),
                  G_SIGNAL_RUN_FIRST,
                  0,
     @@ -123,7 +123,7 @@
      
      
        signals [VARIABLE_INSERTED] =
     -    g_signal_new ("variable_inserted",
     +    g_signal_new ("variable-inserted",
                  G_TYPE_FROM_CLASS (class),
                  G_SIGNAL_RUN_FIRST,
                  0,
     @@ -135,7 +135,7 @@
      
      
        signals [VARIABLES_DELETED] =
     -    g_signal_new ("variables_deleted",
     +    g_signal_new ("variables-deleted",
                  G_TYPE_FROM_CLASS (class),
                  G_SIGNAL_RUN_FIRST,
                  0,
     
     But it doesn't solve the whole problem.  One oddity is that
     delete_variables_callback doesn't delete any columns from the
     datasheet, which it seems that it should, but I don't think
     that's the issue here.
     -- 
     Ben Pfaff 
     http://benpfaff.org

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

signature.asc
Description: Digital signature