[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/23] iotests: Filter $SOCK_DIR
From: |
Max Reitz |
Subject: |
Re: [PATCH 04/23] iotests: Filter $SOCK_DIR |
Date: |
Fri, 11 Oct 2019 09:54:07 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
On 10.10.19 20:42, Eric Blake wrote:
> On 10/10/19 10:24 AM, Max Reitz wrote:
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> tests/qemu-iotests/common.filter | 8 ++++++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/qemu-iotests/common.filter
>> b/tests/qemu-iotests/common.filter
>> index 9f418b4881..cd42f5e7e3 100644
>> --- a/tests/qemu-iotests/common.filter
>> +++ b/tests/qemu-iotests/common.filter
>> @@ -43,7 +43,8 @@ _filter_qom_path()
>> # replace occurrences of the actual TEST_DIR value with TEST_DIR
>> _filter_testdir()
>> {
>> - $SED -e "s#$TEST_DIR/#TEST_DIR/#g"
>> + $SED -e "s#$TEST_DIR/#TEST_DIR/#g" \
>> + -e "s#$SOCK_DIR/#SOCK_DIR/#g"
>
> Do we want to output a literal 'SOCK_DIR' (every test that uses it has
> to update their expected output), or can we make this also output a
> literal 'TEST_DIR' (output is a bit more confusing on which dir to look
> in, but fewer files to touch)? Your preference.
There’s another advantage to filtering it to be TEST_DIR, and that’s the
fact that if $TEST_DIR and $SOCK_DIR are the same, we will always
replace $SOCK_DIR by TEST_DIR.
But I still preferred filtering it to be SOCK_DIR, because that seemed
to me like we would have done it had we had a SOCK_DIR from the start.
> Reviewed-by: Eric Blake <address@hidden>
Thanks for reviewing!
Max
signature.asc
Description: OpenPGP digital signature
- [PATCH 01/23] iotests: Introduce $SOCK_DIR, (continued)
- [PATCH 01/23] iotests: Introduce $SOCK_DIR, Max Reitz, 2019/10/10
- [PATCH 02/23] iotests.py: Store socket files in $SOCK_DIR, Max Reitz, 2019/10/10
- [PATCH 03/23] iotests.py: Add @base_dir to FilePaths etc., Max Reitz, 2019/10/10
- [PATCH 04/23] iotests: Filter $SOCK_DIR, Max Reitz, 2019/10/10
- Re: [PATCH 04/23] iotests: Filter $SOCK_DIR, Eric Blake, 2019/10/10
- [PATCH 06/23] iotests/083: Create socket in $SOCK_DIR, Max Reitz, 2019/10/10
- [PATCH 05/23] iotests: Let common.nbd create socket in $SOCK_DIR, Max Reitz, 2019/10/10
- [PATCH 07/23] iotests/140: Create socket in $SOCK_DIR, Max Reitz, 2019/10/10