[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/23] iotests/194: Create sockets in $SOCK_DIR
From: |
Max Reitz |
Subject: |
Re: [PATCH 14/23] iotests/194: Create sockets in $SOCK_DIR |
Date: |
Fri, 11 Oct 2019 09:55:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
On 10.10.19 21:43, Eric Blake wrote:
> On 10/10/19 10:24 AM, Max Reitz wrote:
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> tests/qemu-iotests/194 | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/qemu-iotests/194 b/tests/qemu-iotests/194
>> index d746ab1e21..72e47e8833 100755
>> --- a/tests/qemu-iotests/194
>> +++ b/tests/qemu-iotests/194
>> @@ -26,8 +26,8 @@ iotests.verify_platform(['linux'])
>> with iotests.FilePath('source.img') as source_img_path, \
>> iotests.FilePath('dest.img') as dest_img_path, \
>
> Any reason these are still two iotests.FilePath(),
>
>> - iotests.FilePath('migration.sock') as migration_sock_path, \
>> - iotests.FilePath('nbd.sock') as nbd_sock_path, \
>> + iotests.FilePaths(['migration.sock', 'nbd.sock'],
>> iotests.sock_dir) as \
>> + [migration_sock_path, nbd_sock_path], \
>
> while you joined this into one iotests.FilePaths()? Doesn't affect
> correctness, but does raise a consistency issue (I noticed it again in
> the untouched part of patch 17).
The migration.sock FilePath line would have exceeded 80 characters, so I
would’ve had to wrap it. Thus I decided I might as well make it a
FilePaths.
I didn’t dare touch the surrounding code, because that would have
required me to explain myself in the commit message. O:-)
Max
>> iotests.VM('source') as source_vm, \
>> iotests.VM('dest') as dest_vm:
>>
>
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 11/23] iotests/182: Create socket in $SOCK_DIR, (continued)
- [PATCH 12/23] iotests/183: Create socket in $SOCK_DIR, Max Reitz, 2019/10/10
- [PATCH 13/23] iotests/192: Create socket in $SOCK_DIR, Max Reitz, 2019/10/10
- [PATCH 14/23] iotests/194: Create sockets in $SOCK_DIR, Max Reitz, 2019/10/10
- [PATCH 15/23] iotests/201: Create socket in $SOCK_DIR, Max Reitz, 2019/10/10
- [PATCH 16/23] iotests/205: Create socket in $SOCK_DIR, Max Reitz, 2019/10/10
- [PATCH 17/23] iotests/208: Create socket in $SOCK_DIR, Max Reitz, 2019/10/10
- [PATCH 18/23] iotests/209: Create socket in $SOCK_DIR, Max Reitz, 2019/10/10
- [PATCH 19/23] iotests/222: Create socket in $SOCK_DIR, Max Reitz, 2019/10/10