[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 5/5] Revert "mirror: Only mirror granularity-aligned chunks"
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v2 5/5] Revert "mirror: Only mirror granularity-aligned chunks" |
Date: |
Fri, 11 Oct 2019 12:07:11 +0300 |
This reverts commit 9adc1cb49af8d4e54f57980b1eed5c0a4b2dafa6.
"mirror: Only mirror granularity-aligned chunks"
Since previous commit unaligned chunks are supported by
do_sync_target_write.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
block/mirror.c | 29 -----------------------------
1 file changed, 29 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 1ed1d79ff8..eecb2d5793 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -1488,15 +1488,6 @@ static void bdrv_mirror_top_child_perm(BlockDriverState
*bs, BdrvChild *c,
*nshared = BLK_PERM_ALL;
}
-static void bdrv_mirror_top_refresh_limits(BlockDriverState *bs, Error **errp)
-{
- MirrorBDSOpaque *s = bs->opaque;
-
- if (s && s->job && s->job->copy_mode == MIRROR_COPY_MODE_WRITE_BLOCKING) {
- bs->bl.request_alignment = s->job->granularity;
- }
-}
-
/* Dummy node that provides consistent read to its users without requiring it
* from its backing file and that allows writes on the backing file chain. */
static BlockDriver bdrv_mirror_top = {
@@ -1509,7 +1500,6 @@ static BlockDriver bdrv_mirror_top = {
.bdrv_co_block_status = bdrv_co_block_status_from_backing,
.bdrv_refresh_filename = bdrv_mirror_top_refresh_filename,
.bdrv_child_perm = bdrv_mirror_top_child_perm,
- .bdrv_refresh_limits = bdrv_mirror_top_refresh_limits,
};
static BlockJob *mirror_start_job(
@@ -1657,25 +1647,6 @@ static BlockJob *mirror_start_job(
s->should_complete = true;
}
- /*
- * Must be called before we start tracking writes, but after
- *
- * ((MirrorBlockJob *)
- * ((MirrorBDSOpaque *)
- * mirror_top_bs->opaque
- * )->job
- * )->copy_mode
- *
- * has the correct value.
- * (We start tracking writes as of the following
- * bdrv_create_dirty_bitmap() call.)
- */
- bdrv_refresh_limits(mirror_top_bs, &local_err);
- if (local_err) {
- error_propagate(errp, local_err);
- goto fail;
- }
-
s->dirty_bitmap = bdrv_create_dirty_bitmap(bs, granularity, NULL, errp);
if (!s->dirty_bitmap) {
goto fail;
--
2.21.0
- [PATCH v2 0/5] active-mirror: support unaligned guest operations, Vladimir Sementsov-Ogievskiy, 2019/10/11
- [PATCH v2 3/5] block/block-backend: add blk_co_pwritev_part, Vladimir Sementsov-Ogievskiy, 2019/10/11
- [PATCH v2 2/5] block/mirror: simplify do_sync_target_write, Vladimir Sementsov-Ogievskiy, 2019/10/11
- [PATCH v2 4/5] block/mirror: support unaligned write in active mirror, Vladimir Sementsov-Ogievskiy, 2019/10/11
- [PATCH v2 5/5] Revert "mirror: Only mirror granularity-aligned chunks",
Vladimir Sementsov-Ogievskiy <=
- [PATCH v2 1/5] hbitmap: handle set/reset with zero length, Vladimir Sementsov-Ogievskiy, 2019/10/11
- Re: [PATCH v2 0/5] active-mirror: support unaligned guest operations, Max Reitz, 2019/10/18