[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/5] active-mirror: support unaligned guest operations
From: |
Max Reitz |
Subject: |
Re: [PATCH v2 0/5] active-mirror: support unaligned guest operations |
Date: |
Fri, 18 Oct 2019 17:54:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
On 11.10.19 11:07, Vladimir Sementsov-Ogievskiy wrote:
> Commit 9adc1cb49af8d fixed a bug about unaligned (to dirty bitmap
> granularity) guest writes (and discards) by simply requesting
> corresponding alignment on mirror-top filter. However forcing large
> alignment obviously decreases performance of unaligned requests.
>
> So it's time for a new solution which is in 04. And 05 reverts
> 9adc1cb49af8d.
>
> v2:
> 01: new fix (do we need it for stable?)
I don’t know? :-)
I’ll just add the stable tag for good measure, I suppose it can’t hurt.
> 02,03,05: add Max's r-b
> 04: fix bitmap handling
> improve comments
>
> Vladimir Sementsov-Ogievskiy (5):
> hbitmap: handle set/reset with zero length
> block/mirror: simplify do_sync_target_write
> block/block-backend: add blk_co_pwritev_part
> block/mirror: support unaligned write in active mirror
> Revert "mirror: Only mirror granularity-aligned chunks"
>
> include/sysemu/block-backend.h | 4 +
> block/block-backend.c | 17 +++-
> block/mirror.c | 181 ++++++++++++++++-----------------
> util/hbitmap.c | 8 ++
> 4 files changed, 114 insertions(+), 96 deletions(-)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
signature.asc
Description: OpenPGP digital signature
- [PATCH v2 0/5] active-mirror: support unaligned guest operations, Vladimir Sementsov-Ogievskiy, 2019/10/11
- [PATCH v2 3/5] block/block-backend: add blk_co_pwritev_part, Vladimir Sementsov-Ogievskiy, 2019/10/11
- [PATCH v2 2/5] block/mirror: simplify do_sync_target_write, Vladimir Sementsov-Ogievskiy, 2019/10/11
- [PATCH v2 4/5] block/mirror: support unaligned write in active mirror, Vladimir Sementsov-Ogievskiy, 2019/10/11
- [PATCH v2 5/5] Revert "mirror: Only mirror granularity-aligned chunks", Vladimir Sementsov-Ogievskiy, 2019/10/11
- [PATCH v2 1/5] hbitmap: handle set/reset with zero length, Vladimir Sementsov-Ogievskiy, 2019/10/11
- Re: [PATCH v2 0/5] active-mirror: support unaligned guest operations,
Max Reitz <=