|
From: | Eric Blake |
Subject: | Re: [PATCH v2 00/23] iotests: Add and use $SOCK_DIR |
Date: | Thu, 17 Oct 2019 09:59:12 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
On 10/17/19 8:31 AM, Max Reitz wrote:
Hi, Perhaps the main reason we cannot run important tests such as 041 in CI is that when they care Unix sockets in $TEST_DIR, the path may become too long to connect to them. To get by this problem, this series lets the check script create a new temporary directory (mktemp -d) and then makes the iotests use it for all Unix sockets. v2: - Patch 1: Use mkdir -p
I just thought of another potential concern there - what do you think of my response there? Depending on how that thread goes, it may work to just amend the commit or take it as-is without having to go to a full v3 posting...
- Patches 4/23: Only add the $SOCK_DIR replacement line in patch 4 and only drop the $TEST_DIR line in patch 23 (Took Eric’s R-b on both because that’s how I interpreted his comments)
Yes, looks like you handled that well. My R-b is okay there. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |