[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 23/23] iotests: Drop TEST_DIR filter from _filter_nbd
From: |
Thomas Huth |
Subject: |
Re: [PATCH v2 23/23] iotests: Drop TEST_DIR filter from _filter_nbd |
Date: |
Thu, 17 Oct 2019 17:58:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 17/10/2019 15.31, Max Reitz wrote:
> Sockets should be placed into $SOCK_DIR instead of $TEST_DIR, so remove
> the $TEST_DIR filter from _filter_nbd.
>
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> tests/qemu-iotests/common.filter | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/common.filter
> b/tests/qemu-iotests/common.filter
> index 0ee6042524..f870e00e44 100644
> --- a/tests/qemu-iotests/common.filter
> +++ b/tests/qemu-iotests/common.filter
> @@ -221,7 +221,6 @@ _filter_nbd()
> # Filter out the TCP port number since this changes between runs.
> $SED -e '/nbd\/.*\.c:/d' \
> -e 's#127\.0\.0\.1:[0-9]*#127.0.0.1:PORT#g' \
> - -e "s#?socket=$TEST_DIR#?socket=TEST_DIR#g" \
> -e "s#?socket=$SOCK_DIR#?socket=SOCK_DIR#g" \
> -e 's#\(foo\|PORT/\?\|.sock\): Failed to .*$#\1#'
> }
>
Reviewed-by: Thomas Huth <address@hidden>
- [PATCH v2 17/23] iotests/208: Create socket in $SOCK_DIR, (continued)
- [PATCH v2 17/23] iotests/208: Create socket in $SOCK_DIR, Max Reitz, 2019/10/17
- [PATCH v2 21/23] iotests/240: Create socket in $SOCK_DIR, Max Reitz, 2019/10/17
- [PATCH v2 18/23] iotests/209: Create socket in $SOCK_DIR, Max Reitz, 2019/10/17
- [PATCH v2 19/23] iotests/222: Create socket in $SOCK_DIR, Max Reitz, 2019/10/17
- [PATCH v2 22/23] iotests/267: Create socket in $SOCK_DIR, Max Reitz, 2019/10/17
- [PATCH v2 20/23] iotests/223: Create socket in $SOCK_DIR, Max Reitz, 2019/10/17
- [PATCH v2 23/23] iotests: Drop TEST_DIR filter from _filter_nbd, Max Reitz, 2019/10/17
- Re: [PATCH v2 23/23] iotests: Drop TEST_DIR filter from _filter_nbd,
Thomas Huth <=
- Re: [PATCH v2 00/23] iotests: Add and use $SOCK_DIR, Eric Blake, 2019/10/17
- Re: [PATCH v2 00/23] iotests: Add and use $SOCK_DIR, Max Reitz, 2019/10/18