[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 2/3] block/file-posix: Detect XFS with CONFIG_FALLOCATE
From: |
Kevin Wolf |
Subject: |
Re: [RFC 2/3] block/file-posix: Detect XFS with CONFIG_FALLOCATE |
Date: |
Fri, 25 Oct 2019 12:19:20 +0200 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
Am 25.10.2019 um 11:58 hat Max Reitz geschrieben:
> We will need this for the next patch.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/file-posix.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/file-posix.c b/block/file-posix.c
> index 695fcf740d..5cd54c8bff 100644
> --- a/block/file-posix.c
> +++ b/block/file-posix.c
> @@ -149,7 +149,7 @@ typedef struct BDRVRawState {
> int perm_change_flags;
> BDRVReopenState *reopen_state;
>
> -#ifdef CONFIG_XFS
> +#if defined(CONFIG_XFS) || defined(CONFIG_FALLOCATE)
> bool is_xfs:1;
> #endif
> bool has_discard:1;
> @@ -667,7 +667,7 @@ static int raw_open_common(BlockDriverState *bs, QDict
> *options,
> }
> #endif
>
> -#ifdef CONFIG_XFS
> +#if defined(CONFIG_XFS) || defined(CONFIG_FALLOCATE)
> if (platform_test_xfs_fd(s->fd)) {
platform_test_xfs_fd() is defined in a header file from xfsprogs. I
don't think you can call that without CONFIG_XFS, it would break the
build.
> s->is_xfs = true;
> }
Kevin
[RFC 3/3] block/file-posix: Let post-EOF fallocate serialize, Max Reitz, 2019/10/25
Re: [RFC 0/3] block/file-posix: Work around XFS bug, Vladimir Sementsov-Ogievskiy, 2019/10/25